Checkin Setup

listy · (This post was last modified: 06-09-2020, 10:19 AM by listy.)

Hi!
Just noticed that there is no Checkin Setup for nodes of Workflow Editor in 4.8.
Is this a bug?
How i can find this?

Also when i try to save any table view i got this spt.dg_table.save_search is deprecated.

"config/process" table is the only place where i can change checkin-setup for nodes in 4.8

***remkonoteboom*** · 06-09-2020, 03:22 PM

"Also when i try to save any table view i got this spt.dg_table.save_search is deprecated."

Yes, this function was moved. Please log this as a github issue so we can fix this. It should still save correctly, so ignore until fix.

listy · 06-09-2020, 03:34 PM

(06-09-2020, 03:22 PM)remkonoteboom Wrote: Yes, this function was moved. Please log this as a github issue so we can fix this. It should still save correctly, so ignore until fix.

No, it isn't saving table state.

But what about Checkin Setup? Big Grin

***remkonoteboom*** · (This post was last modified: 06-09-2020, 03:54 PM by remkonoteboom.)

As for check-in setup, we found that we weren't ever using this since a lot of the functionality check-in widget was lost when the browser stopped really supporting Java applets. This left a lot of this functionality of the check-ins not function. Coupled with the new way that the pipeline editor saves, I seems this was disabled and deprecated.

You can see this in line 3853 of src/tactic/ui/tools/pipeline_wdg.py

Code:
3852    # DEPRECATED: The old check-in widget is basically not functional anymore

3853    has_checkins = False

3854    if has_checkins:

Setting has_checkins to True will make it show up there, however the question still remains. What in this is still useful?

listy · 06-09-2020, 04:00 PM

(06-09-2020, 03:54 PM)remkonoteboom Wrote: As for check-in setup, we found that we weren't ever using this since a lot of the functionality check-in widget was lost when the browser stopped really supporting Java applets. This left a lot of this functionality of the check-ins not function. Coupled with the new way that the pipeline editor saves, I seems this was disabled and deprecated.

You can see this in line 3853 of src/tactic/ui/tools/pipeline_wdg.py

Code:
3852 # DEPRECATED: The old check-in widget is basically not functional anymore 3853 has_checkins = False 3854 if has_checkins:

Setting has_checkins to True will make it show up there, however the question still remains. What in this is still useful?

I do support it in my TH and use checkin modes like file/multi-file. And also predefine contexts and subcontexts Smile