TACTIC Open Source
Converted TableLayoutWdg to use <div> elements - Printable Version

+- TACTIC Open Source (http://forum.southpawtech.com)
+-- Forum: TACTIC Open Source (http://forum.southpawtech.com/forumdisplay.php?fid=3)
+--- Forum: TACTIC Discussion (http://forum.southpawtech.com/forumdisplay.php?fid=4)
+--- Thread: Converted TableLayoutWdg to use <div> elements (/showthread.php?tid=231)

Pages: 1 2 3 4 5 6


RE: Converted TableLayoutWdg to use <div> elements - remkonoteboom - 08-02-2021

The biggest remaining issue that I am aware of at moment is when trying to resize a column if there is grouping. The presence of the grouping seems to cause the widths to go change is bizarre ways.


RE: Converted TableLayoutWdg to use <div> elements - remkonoteboom - 08-03-2021

I added another fix for dealing with grouped tables.


RE: Converted TableLayoutWdg to use <div> elements - listy - 08-03-2021

(08-03-2021, 06:45 PM)remkonoteboom Wrote: I added another fix for dealing with grouped tables.
Double checked your fix, and I still have issues when groups are enabled


RE: Converted TableLayoutWdg to use <div> elements - remkonoteboom - 08-03-2021

It seems to mess up on the second resize.


RE: Converted TableLayoutWdg to use <div> elements - remkonoteboom - 08-05-2021

I committed a small fix. This works on a wide variety of cases that I have. However, on occasion, if I press search and manipulate the columns, sometimes, I can see some wonky behavior, but I can't quite place it. Sorry for all of the iterations, but it's a pretty big change underneath.


RE: Converted TableLayoutWdg to use <div> elements - listy - 08-06-2021

This fix actually fixed the issues. I will let You know if i found something again.
Thanks!
We are 1 step from making all cells aligned in center!


RE: Converted TableLayoutWdg to use <div> elements - remkonoteboom - 08-07-2021

Do you think there is anything stopping me from merging this pull request? As far as I can tell (with the limited testing I have available), there are no major issues and it is already better that what is there now. If there are any issues, I will try to fix them quickly.


RE: Converted TableLayoutWdg to use <div> elements - listy - 08-07-2021

I think nothing stops from merging to main branch.
I will do tests on prod server, and roll back if something will not work.

Also, i am waiting for Diego's pull request, for the scrollbars. Perfectly working in the prod now.


RE: Converted TableLayoutWdg to use <div> elements - remkonoteboom - 08-07-2021

Ok, I will do merge it. I don't know of Diego's pull request. It is not on GitHub.


RE: Converted TableLayoutWdg to use <div> elements - listy - 08-07-2021

(08-07-2021, 06:55 PM)remkonoteboom Wrote: Ok, I will do merge it.  I don't know of Diego's pull request.  It is not on GitHub.
I is only in his branch, need to poke him one more time  Tongue